Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] improving integration tests #43

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

nrkljo
Copy link
Contributor

@nrkljo nrkljo commented Apr 11, 2024

Improving integration tests. This PR should adress the flowing JIRAs:

  • DBZ-7539
  • DBZ-7540
  • DBZ-7542
  • DBZ-7543
  • DBZ-7556

@Naros
Copy link
Member

Naros commented Apr 11, 2024

Hi @nrkljo, I think we should remove the @Flaky annotations if these fixes address those Jira issues, i.e.:

    @Test
    @FixFor("DBZ-1128")
    @Flaky("DBZ-7539")
    public void restartInTheMiddleOfTxAfterSnapshot() throws Exception {
        restartInTheMiddleOfTx(true, false);
    }

This way, we can be sure that the first execution isn't retried, and we're not seeing green due to the reattempt.

@nrkljo
Copy link
Contributor Author

nrkljo commented Apr 12, 2024

@Naros, I was going to ask about that. I have one in the pipe...

@nrkljo nrkljo merged commit ce0b3f6 into debezium:main Apr 15, 2024
5 checks passed
@nrkljo nrkljo deleted the DBZ-7539 branch April 15, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants